Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc example #20559

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Update doc example #20559

merged 1 commit into from
Sep 10, 2020

Conversation

mavasani
Copy link
Contributor

IDE0005 is a special diagnostic that needs an additional step of turning on XML doc comments for the project to see these warnings/errors on build - see dotnet/roslyn#41640 for context.

I have instead switched to a different IDE diagnostic that does not need any additional steps, so the example works by default. I verified that the updated example produces IDE0040 warnings on build with latest .NET5 RC2 SDK installed from https://github.com/dotnet/installer#installers-and-binaries

@dotnet-bot dotnet-bot added this to the September 2020 milestone Sep 10, 2020
@gewarren gewarren merged commit 6cc0623 into dotnet:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants