Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSL/TLS articles to conceptual docs #32194

Merged
merged 16 commits into from
Jan 13, 2023
Merged

Add SSL/TLS articles to conceptual docs #32194

merged 16 commits into from
Jan 13, 2023

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Nov 4, 2022

Summary

Closes #31995.

@dotnet-bot dotnet-bot added this to the November 2022 milestone Nov 4, 2022
IEvangelist
IEvangelist reviewed Nov 4, 2022
View reviewed changes
docs/core/extensions/sslstream-migration-from-framework.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-migration-from-framework.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-migration-from-framework.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-migration-from-framework.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-troubleshooting.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
@rzikm rzikm marked this pull request as ready for review December 1, 2022 15:27
@rzikm rzikm requested a review from a team as a code owner December 1, 2022 15:27
@rzikm rzikm requested a review from wfurt December 1, 2022 15:31
wfurt
wfurt reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good to me.
Sorry for late feedback.

docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-migration-from-framework.md Outdated Show resolved Hide resolved
@rzikm
Copy link
Member Author

rzikm commented Dec 15, 2022

@IEvangelist how do ms.author aliases work? do I need to register mine somewhere?

@rzikm rzikm requested a review from wfurt December 15, 2022 21:03
@gewarren
Copy link
Contributor

@IEvangelist how do ms.author aliases work? do I need to register mine somewhere?

ms.author is your Microsoft alias, not your GitHub account. You don't need to register it.

rzikm and others added 2 commits January 4, 2023 12:21
@rzikm @bartonjs
Update docs/core/extensions/sslstream-best-practices.md
1c973ef 
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@rzikm
Review feedback
e481948
@rzikm rzikm requested a review from bartonjs January 6, 2023 15:00
@rzikm
Copy link
Member Author

rzikm commented Jan 6, 2023

@wfurt, @bartonjs Can you please take another look?

@rzikm rzikm requested a review from IEvangelist January 9, 2023 08:37
IEvangelist
IEvangelist requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of grammatical, and style-based feedback here. All of this is minor but should be included in this PR. I'll approve and merge this once it's addressed. I do have one larger question, as it relates to the amount of content in the "migrate" article.

docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-best-practices.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-troubleshooting.md Outdated Show resolved Hide resolved
docs/core/extensions/sslstream-troubleshooting.md Outdated Show resolved Hide resolved
docs/fundamentals/toc.yml Outdated Show resolved Hide resolved
docs/fundamentals/toc.yml Outdated Show resolved Hide resolved
docs/fundamentals/toc.yml Outdated Show resolved Hide resolved
rzikm and others added 3 commits January 11, 2023 13:46
@rzikm @IEvangelist
Apply suggestions from code review
7b58d2e 
Co-authored-by: David Pine <david.pine@microsoft.com>
@rzikm
Replace `` by xref
68871b3
@rzikm
Fix xref
5d83291
IEvangelist
IEvangelist approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist merged commit 3f37923 into main Jan 13, 2023
@IEvangelist IEvangelist deleted the tls-ssl-docs branch January 13, 2023 14:59
@gewarren gewarren mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@wfurt wfurt Awaiting requested review from wfurt

@bartonjs bartonjs Awaiting requested review from bartonjs

Assignees

@IEvangelist IEvangelist

Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
December 2022
Development

Successfully merging this pull request may close these issues.

System.Net.Security docs improvements
7 participants
@rzikm @gewarren @IEvangelist @bartonjs @wfurt @BillWagner @dotnet-bot