Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify default value #36055

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Clarify default value #36055

merged 1 commit into from
Jun 30, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jun 29, 2023 •
edited by github-actions bot
Loading

Fixes #35661.

Internal previews

📄 File 🔗 Preview link
docs/core/project-sdk/msbuild-props.md MSBuild reference for .NET SDK projects

@dotnet-bot dotnet-bot added this to the June 2023 milestone Jun 29, 2023
@gewarren gewarren requested a review from a team June 29, 2023 17:12
BillWagner
BillWagner approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 360a23d into main Jun 30, 2023
@gewarren gewarren deleted the gewarren-patch-4 branch June 30, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

Incorrect documentation of EmbeddedResourceUseDependentUponConvention-default
3 participants
@gewarren @BillWagner @dotnet-bot