Freshness pass on access modifiers #39883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet#39819 Perform an edit pass, and address open issues: - Fixes dotnet#25518: Explain that all partial declarations must match, and not declaring an accessibility means means it has any declared accessibility on the other declaration. - Fixes dotnet#27155 Ret-con this from the day when `record` structs didn't exist. Now, `record` is defined as a modifier on either a `struct` or `class` type. - Fixes dotnet#27196: Added clarifying remarks that "type" had meant a "type" declared directly in a namespace. This still has meaning in the programming guide, rather than using the more normative language of the standard. - Fixes dotnet#27197: Update the language for clarity.
gewarren
approved these changes
Mar 11, 2024
docs/csharp/programming-guide/classes-and-structs/access-modifiers.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/classes-and-structs/access-modifiers.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/classes-and-structs/access-modifiers.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/classes-and-structs/access-modifiers.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/classes-and-structs/access-modifiers.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/classes-and-structs/access-modifiers.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #39819
Perform an edit pass, and address open issues:
internal) when combined with partial #25518: Explain that all partial declarations must match, and not declaring an accessibility means means it has any declared accessibility on the other declaration.recordstructs didn't exist. Now,recordis defined as a modifier on either astructorclasstype.Internal previews