F# , add chapter on opening with global specifier #40809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chapter on global keyword
goswinr
requested review from
BillWagner,
KathleenDollard and
a team
as code owners
dotnet-policy-service
bot
added
the
community-contribution
|
I believe this follows the F# spec: |
goswinr
changed the title
vzarytovskii
requested changes
May 8, 2024
docs/fsharp/language-reference/import-declarations-the-open-keyword.md
Outdated
Show resolved
Hide resolved
goswinr
changed the title
vzarytovskii
approved these changes
May 8, 2024
psfinaki
reviewed
May 9, 2024
docs/fsharp/language-reference/import-declarations-the-open-keyword.md
Outdated
Show resolved
Hide resolved
psfinaki
reviewed
May 9, 2024
docs/fsharp/language-reference/import-declarations-the-open-keyword.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
|
Hi @goswinr This is ready to merge, once you fix the markdown lint issues. Thanks for helping us improve. |
BillWagner
approved these changes
May 10, 2024
There was a problem hiding this comment.
Thanks again @goswinr
I'll merge this now. You should see the changes on the live site in the next day or so on our regular publishing cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add chapter on
globalspecifier inopenstatements.Please reword if required.
To address dotnet/fsharp#17124
Internal previews
openkeyword