Skip to content

Port System.ComponentModel new docs (second pass) #10214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

carlossanlop
Copy link
Contributor

Ports some missed in the first pass.

Contributes to dotnet/runtime#105983

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-componentmodel

This comment was marked as outdated.

@carlossanlop
Copy link
Contributor Author

@buyaa-n @steveharter can you please give me a code review?

@carlossanlop
Copy link
Contributor Author

Ping @gewarren and @dotnet/area-system-componentmodel , can I please get a review?

@carlossanlop carlossanlop enabled auto-merge (squash) August 12, 2024 18:50
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Copy link

Learn Build status updates of commit 1c5a922:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.ComponentModel/TypeDescriptionProvider.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.ComponentModel/TypeDescriptionProvider.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'Docs' start tag on line 439 position 8 does not match the end tag of 'summary'. Line 454, position 11.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 31f88d5:

✅ Validation status: passed

File Status Preview URL Details
xml/System.ComponentModel/ComponentResourceManager.xml ✅Succeeded View
xml/System.ComponentModel/CustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/ICustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/PropertyDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptionProvider.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptor.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit 9ed6ee3 into dotnet:main Aug 13, 2024
3 checks passed
@carlossanlop carlossanlop deleted the PortSystemComponentModel branch August 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants