Skip to content

Conversation

voroninp
Copy link
Contributor

As discussed in #10081, it's worth giving a hint to TimeProvder users about existence of FakeTimeProvider which helps with testing.

Fixes #10081

As discussed in #10081, it's worth giving a hint to `TimeProvder` users about existence of `FakeTimeProvider` which helps with testing.
@voroninp voroninp requested a review from a team as a code owner August 15, 2024 19:15
@ghost ghost added the area-System.DateTime label Aug 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 15, 2024
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @voroninp

@gewarren gewarren enabled auto-merge (squash) August 15, 2024 19:24
@voroninp
Copy link
Contributor Author

@gewarren , hm, is it a valid way to reference code in xmldcos from non-referenced assembly?

Copy link

Learn Build status updates of commit 321c2ba:

✅ Validation status: passed

File Status Preview URL Details
xml/System/TimeProvider.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e066fd2:

✅ Validation status: passed

File Status Preview URL Details
xml/System/TimeProvider.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 27f7094 into dotnet:main Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.DateTime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Reference FakeTimeProvider in xml comments to TimeProvider class.
2 participants