Skip to content

Conversation

gewarren
Copy link
Contributor

(Hide whitespace changes.)

Compilation error introduced by #8741 (by me).

@gewarren gewarren requested a review from a team as a code owner August 29, 2024 02:42
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 29, 2024
@ghost
Copy link

ghost commented Aug 29, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@ghost
Copy link

ghost commented Aug 29, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link

Learn Build status updates of commit 4c49642:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Collections.Generic/CollectionExtensions.xml ⚠️Warning View Details
snippets/csharp/Microsoft.Win32.SafeHandles/SafeWaitHandle/Overview/Project.csproj ✅Succeeded
snippets/csharp/Microsoft.Win32.SafeHandles/SafeWaitHandle/Overview/sample.cs ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeWaitHandle.xml ✅Succeeded View

xml/System.Collections.Generic/CollectionExtensions.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getdefaultassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getdefaultgroup was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getdefaultruntimefileassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getruntimeassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getruntimefileassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getruntimegroup was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 1975883 into dotnet:main Aug 29, 2024
3 checks passed
@gewarren gewarren deleted the fix-sample branch August 29, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants