Remove over-specific and incorrect documentation about HMAC key lengths #10472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-System.Security
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones |
gewarren
approved these changes
Sep 30, 2024
|
Learn Build status updates of commit 7dff165: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
bartonjs
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The documentation for the key length in
IncrementalHash.CreateHMACwas incorrect regarding how the key adjustment is done, and used the hash size, not the block size, to indicate when the key would be adjusted.Based on discussion in #8920, the fix is to just remove the erroneous content.
Fixes #8920.