-
Notifications
You must be signed in to change notification settings - Fork 1.6k
CI Update - .NET 10 Preview 7 #11680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=560189&view=results source_repo.branch:dotnet10-pre7 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Let's
<Parameter Name="writeMessageType" Type="System.Net.WebSockets.WebSocketMessageType" /> | ||
<Parameter Name="ownsWebSocket" Type="System.Boolean" /> | ||
</Parameters> | ||
<Docs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I happened to notice that the tripleslash comments from the source code didn't propagate here -- is this to be expected? (the comments were present in the source from the start)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarnaViire This assembly doesn't have its "source of truth" in the runtime repo (///). Would you like me to try and reconcile the docs between runtime repo and dotnet-api-docs repo and then make the runtime repo the source of truth for System.Net.WebSockets?
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
<Parameter Name="writeMessageType" Type="System.Net.WebSockets.WebSocketMessageType" /> | ||
<Parameter Name="ownsWebSocket" Type="System.Boolean" /> | ||
</Parameters> | ||
<Docs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarnaViire This assembly doesn't have its "source of truth" in the runtime repo (///). Would you like me to try and reconcile the docs between runtime repo and dotnet-api-docs repo and then make the runtime repo the source of truth for System.Net.WebSockets?
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=560189&view=results
source_repo.branch:dotnet10-pre7
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Summary
Fixes #11390.