Skip to content

CI Update - .NET 10 Preview 7 #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025
Merged

CI Update - .NET 10 Preview 7 #11680

merged 4 commits into from
Aug 13, 2025

Conversation

gewarren
Copy link
Contributor

Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=560189&view=results
source_repo.branch:dotnet10-pre7
source_repo.url:https://apidrop.visualstudio.com/_git/binaries

Summary

Fixes #11390.

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=560189&view=results
 source_repo.branch:dotnet10-pre7
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@gewarren gewarren marked this pull request as ready for review August 13, 2025 04:25
@gewarren gewarren enabled auto-merge (squash) August 13, 2025 04:25
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

<Parameter Name="writeMessageType" Type="System.Net.WebSockets.WebSocketMessageType" />
<Parameter Name="ownsWebSocket" Type="System.Boolean" />
</Parameters>
<Docs>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happened to notice that the tripleslash comments from the source code didn't propagate here -- is this to be expected? (the comments were present in the source from the start)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarnaViire This assembly doesn't have its "source of truth" in the runtime repo (///). Would you like me to try and reconcile the docs between runtime repo and dotnet-api-docs repo and then make the runtime repo the source of truth for System.Net.WebSockets?

Copy link

PoliCheck Scan Report

The following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

<Parameter Name="writeMessageType" Type="System.Net.WebSockets.WebSocketMessageType" />
<Parameter Name="ownsWebSocket" Type="System.Boolean" />
</Parameters>
<Docs>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarnaViire This assembly doesn't have its "source of truth" in the runtime repo (///). Would you like me to try and reconcile the docs between runtime repo and dotnet-api-docs repo and then make the runtime repo the source of truth for System.Net.WebSockets?

@gewarren gewarren merged commit eace29b into main Aug 13, 2025
4 of 5 checks passed
@gewarren gewarren deleted the net10-pre7 branch August 13, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API docs for .NET 10 Preview 7
4 participants