Skip to content

Conversation

jiayi11
Copy link
Member

@jiayi11 jiayi11 commented Feb 26, 2019

Fixes dotnet/corefx#33950
@Lxiamail @mconnew

@jiayi11
Copy link
Member Author

jiayi11 commented Feb 26, 2019

Hi @mairaw, is there a way for me to view what pages looks like after the change?

@jiayi11 jiayi11 changed the title Recommend users to cache serializers created from FromTypes(Type[]) and FormMappings(XmlMapping[]) Recommend users to cache serializers created from FromTypes(Type[]) and FromMappings(XmlMapping[]) Feb 26, 2019
@mairaw
Copy link
Contributor

mairaw commented Feb 26, 2019

Hi @yujayee, on the status box, you can find a line for OpenPublishing.Build with a link to Details. On that, you can find links to the review site and then you can search for the API you're editing.

For example:
https://review.docs.microsoft.com/en-us/dotnet/api/system.xml.serialization.xmlserializer.frommappings?view=netframework-4.7.2&branch=pr-en-us-1964

image

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These LGTM @yujayee
I'll :shipit: now.

@BillWagner BillWagner merged commit b73418e into dotnet:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants