Updates for new Japanese calendar era #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2019
Merged
rpetrusha
added
the
🚧 Hold for related PR
tarekgh
reviewed
Mar 1, 2019
includes/calendar-era.md
Outdated
| @@ -1,4 +1,3 @@ | |||
|
|
|||
| > [!IMPORTANT] | |||
| > A new era in the <xref:System.Globalization.JapaneseCalendar> and <xref:System.Globalization.JapaneseLunisolarCalendar> begins on May 1, 2019. This change affects all applications that use these calendars. See [Handling a new era in the Japanese calendar in .NET](https://blogs.msdn.microsoft.com/dotnet/2018/11/14/handling-a-new-era-in-the-japanese-calendar-in-net/) for more information and to determine whether your applications are affected. See [Prepare your application for the Japanese era change](/windows/uwp/design/globalizing/japanese-era-change) for information on testing your applications on Windows systems to ensure their readiness for the era change. | |||
|
|
|||
| > A new era in the <xref:System.Globalization.JapaneseCalendar> and <xref:System.Globalization.JapaneseLunisolarCalendar> begins on May 1, 2019. This change affects all applications that use these calendars. See [Handling a new era in the Japanese calendar in .NET](https://blogs.msdn.microsoft.com/dotnet/2018/11/14/handling-a-new-era-in-the-japanese-calendar-in-net/) for more information and to determine whether your applications are affected. See [Prepare your application for the Japanese era change](/windows/uwp/design/globalizing/japanese-era-change) for information on testing your applications on Windows systems to ensure their readiness for the era change. See the ["Working with eras"](~/docs/standard/datetime/working-with-calendars.md#working-with-eras) section of the [Working with calendars](~/docs/standard/datetime/working-with-calendars.md) article for additional information and recommendations for using eras in the Japanese calendars. | |||
There was a problem hiding this comment.
The link (/windows/uwp/design/globalizing/japanese-era-change) looks not working. is this a place holder?
There was a problem hiding this comment.
other links looks not working too. I may be missing something but wanted to tell.
There was a problem hiding this comment.
@tarekgh, the links work in live builds but not in review builds. Any content that originates outside of the dotnet/docs repo isn't build as part of this PR, so Windows content isn't built.
New examples also aren't included since they still haven't been merged in the dotnet/samples repo.
tarekgh
approved these changes
Mar 1, 2019
BillWagner
approved these changes
Mar 2, 2019
There was a problem hiding this comment.
This LGTM @rpetrusha
You can 
when you merge the associated samples and you get a clean build.
|
Closing and reopening to begin new build after dotnet/samples#686 was merged. |
mairaw
removed
the
🚧 Hold for related PR
rpetrusha
added
🚧 Hold for related PR
|
Closing and reopening to begin new build before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for new Japanese calendar era
Related to dotnet/samples#686
Contributes to dotnet/docs#10192
Depends on dotnet/docs#10853
//cc @tarekgh