Skip to content

Conversation

v-kents
Copy link
Contributor

@v-kents v-kents commented Mar 6, 2019

Summary

Migrate parameter information from MSDN

Fixes #70857 (https://ceapex.visualstudio.com/CPS/_workitems/edit/70857)

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Mar 7, 2019
@mairaw mairaw added this to the March 2019 milestone Mar 7, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments

mairaw and others added 2 commits March 7, 2019 09:32
@mairaw
Copy link
Contributor

mairaw commented Mar 8, 2019

Can we make the same changes as we did in the other PR to not change the CRLF?

@v-kents
Copy link
Contributor Author

v-kents commented Mar 8, 2019

Dang, sorry. I had looked at it when I switched the other over, and it was saying LF then. Switched back.

@mairaw
Copy link
Contributor

mairaw commented Mar 8, 2019

Thanks! I'm reviewing both PRs today extensively and hopefully we can merge both today!

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was easier to finish the changes myself to speed up the process.

@BillWagner BillWagner merged commit 4e5ca34 into dotnet:master Mar 11, 2019
@v-kents v-kents deleted the task70857 branch March 11, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants