enhancements #2025
Merged
enhancements #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rpetrusha
approved these changes
Mar 12, 2019
|
Like that @rpetrusha? I also need to check after build is done if the @ character on that xref link built successfully or if I need to encode as well. |
mairaw
added
waiting-on-feedback
rpetrusha
reviewed
Apr 9, 2019
xml/System/UriKind.xml
Outdated
|
|
||
| * <xref:System.Uri.%23ctor(System.String,System.UriKind)?displayProperty=nameWithType> | ||
| * <xref:System.Uri.IsWellFormedUriString(System.String,System.UriKind)?displayProperty=nameWithType> | ||
| * <xref:M:System.Uri.TryCreate(System.String,System.UriKind,System.Uri@)?displayProperty=nameWithType> |
There was a problem hiding this comment.
The link is broken, so I think that this needs to be encoded.
mairaw
added
verify-build-before-merge
and removed
waiting-on-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937 plus a few other enhancements