Skip to content

test char #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

test char #2286

merged 1 commit into from
Apr 11, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 10, 2019

See if we can use the @

The build had failed on my previous PR because I had the wrong xref value there

@mairaw mairaw added this to the April 2019 milestone Apr 10, 2019
@mairaw mairaw self-assigned this Apr 10, 2019
@mairaw
Copy link
Contributor Author

mairaw commented Apr 11, 2019

It seems to work with the original character. Should we change or should we encode?
https://review.docs.microsoft.com/en-us/dotnet/api/system.urikind?branch=pr-en-us-2286&view=netframework-4.7.2

rpetrusha
rpetrusha approved these changes Apr 11, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @ works, @mairaw. See https://review.docs.microsoft.com/en-us/dotnet/api/system.uri.trycreate?view=netframework-4.7.2&branch=pr-en-us-2286#System_Uri_TryCreate_System_String_System_UriKind_System_Uri__.

@mairaw mairaw merged commit f9366ec into master Apr 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the test-char branch April 11, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mairaw mairaw

Labels
None yet
Projects
None yet
Milestone
April 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@mairaw @rpetrusha