Port System.Net.WebSockets triple slash comments to Docs #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw @rpetrusha please take a look whenever you get a chance. Adding the area owners @davidsh, @wfurt, @karelz in case they have any additional comments or suggestions. The comments were added without modifications. The only thing I changed was the formatting for reserved keywords. |
karelz
approved these changes
Apr 23, 2019
davidsh
reviewed
Apr 23, 2019
carlossanlop
commented
Apr 23, 2019
carlossanlop
commented
Apr 23, 2019
carlossanlop
commented
Apr 23, 2019
Suggestions provided by davidsh and karelz. Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
mairaw
requested changes
Apr 26, 2019
Suggestions by mairaw Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
|
Suggestions applied! Thanks @mairaw. |
|
If we're making more editorial changes to this structure, ValueWebSocketReceiveResult, we should make sure we make the same editorial changes to the class version of it, WebSocketReceiveResult. |
mairaw
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
Looks good now @carlossanlop. I'll wait until build finishes successfully to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically ported some triple slash source code comments found in System.Net.WebSockets that were not found in dotnet-api-docs.
Fixes #Issue_Number (if available)