-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Port System.Linq.Expressions source comments to Docs #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mairaw @rpetrusha please take a look whenever possible. Adding the area owners @cston, @333fred. Charles, Fred, can you please take a look? The summary messages I ported are all generic and have exactly the same string, so it would be awesome if the code experts could jump in to edit them into some more descriptive and specific summaries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that I'm reading the XML correctly and this adds docs to a bunch of Accept
methods, these look fine to me.
@mairaw @rpetrusha if this looks good enough, can we get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The summaries look good, @carlossanlop, but the parameter descriptions and return values are missing. Would it be possible for you to also add those? The parameter description is, "The visitor to visit this node with." The return value description is "The result of visiting this node."
For the visitor parameter, would it sound better to use the following instead?: "The <see cref="T:System.Linq.Expressions.ExpressionVisitor"> with which this node will be visited." |
Suggested by rpetrusha
@rpetrusha done. |
Thanks for making all of the additional changes, @carlossanlop. I'll merge your PR now. |
Thank you @rpetrusha ! |
Summary
Automatically porting a few triple slash source code comments found in System.Linq.Expressions that were not yet documented in dotnet-api-docs.
Fixes #Issue_Number (if available)