Skip to content

Documented 2 new members for .NET Framework 4.8 #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Documented 2 new members for .NET Framework 4.8 #2334

merged 1 commit into from
Apr 18, 2019

Conversation

rpetrusha
Copy link

Documented 2 new members for .NET Framework 4.8

@rpetrusha rpetrusha added the 🏁 Release: .NET Framework 4.8 Identifies work items for the .NET Framework 4.8 release label Apr 17, 2019
@rpetrusha rpetrusha added this to the April 2019 milestone Apr 17, 2019
@rpetrusha rpetrusha requested a review from mairaw April 17, 2019 18:26
@rpetrusha rpetrusha self-assigned this Apr 17, 2019
@rpetrusha rpetrusha mentioned this pull request Apr 17, 2019
Merged
mairaw
mairaw approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't see this implementation but the base class talks about derived classes implementing these methods without attaching delegates as the preferred way. Did you check what they've done?

@rpetrusha rpetrusha merged commit bdc5c7e into dotnet:master Apr 18, 2019
@rpetrusha rpetrusha deleted the apis-48-new branch May 6, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@rpetrusha rpetrusha

Labels

🏁 Release: .NET Framework 4.8 Identifies work items for the .NET Framework 4.8 release

Projects

None yet

Milestone

April 2019

Development

Successfully merging this pull request may close these issues.

2 participants

@rpetrusha @mairaw