Skip to content

Remove SqlClient-specific info from DbDataReader #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2019
Merged

Remove SqlClient-specific info from DbDataReader #2345

merged 1 commit into from
Apr 21, 2019

Conversation

roji
Copy link
Member

@roji roji commented Apr 20, 2019

On exceptions thrown from DbDataReader.Get{Stream,TextReader}().

See discussion in npgsql/npgsql#2447

@roji
Remove SqlClient-specific info from DbDataReader
d95ae2d 
On exceptions thrown from DbDataReader.Get{Stream,TextReader}().
@roji roji requested a review from stevestein as a code owner April 20, 2019 20:14
@roji roji mentioned this pull request Apr 20, 2019
Closed
rpetrusha
rpetrusha approved these changes Apr 21, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this correction, @roji. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 453f8ce into dotnet:master Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevestein stevestein Awaiting requested review from stevestein

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roji @rpetrusha