Add remark to Directory.Move about exception thrown in all platforms #2358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw @rpetrusha Please take a look whenever you get a chance. This is the first time I add a remark about a breaking change, so I would like to know if I did it correctly or if you'd like me to format it differently. |
|
@danmosemsft @karelz @JeremyKuhne FYI I am adding a documentation remark for the breaking change I merged for Directory.Move. |
rpetrusha
suggested changes
Apr 25, 2019
There was a problem hiding this comment.
Thanks, @carlossanlop. I've left some comments and suggestions.
Suggestions provided by rpetrusha. Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
Suggested by rpetrusha: - The note should be placed in the Remarks section, not the Examples section. - It would be useful to add "See the Note in the Remarks section." to line 3486.
rpetrusha
approved these changes
Apr 26, 2019
|
Thanks for making the additional changes, @carlossanlop. I'll merge your PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding this remark as a followup for this fix, which will be a breaking change starting in 3.0: https://github.com/dotnet/corefx/issues/33486
Fixes #Issue_Number (if available)