Skip to content

Conversation

HoundThe
Copy link
Contributor

Summary

Added simple example how to set HttpClient.Timeout Property based on issue

Fixes #1478

@HoundThe HoundThe requested a review from karelz as a code owner April 25, 2019 23:38
@BillWagner BillWagner added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Apr 26, 2019
@rpetrusha rpetrusha added this to the May 2019 milestone May 10, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HoundThe, for contributing to the dotnet/dotnet-api-docs repo and for adding this example. I've left one comment and a several suggestions.

HoundThe and others added 3 commits May 14, 2019 15:57
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@HoundThe
Copy link
Contributor Author

Sorry for the high number of commits, I am new to this kind of stuff. I applied your suggestions, I hope I understood them correctly.

@rpetrusha
Copy link

The extra commits are not a problem, @HoundThe. Your changes look good; thanks for making them. I'll merge your PR now. The example should be live on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit aa1390a into dotnet:master May 14, 2019
@HoundThe
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not a single line of example?
3 participants