Skip to content

Conversation

rpetrusha
Copy link

Added information on schema validation errors

See #2497. The lack of an adequate example description left a customer expecting that schema validation should succeed when in fact it was expected to fail.

Dependent on dotnet/samples#928

Fixes #2497

@rpetrusha rpetrusha self-assigned this May 24, 2019
@rpetrusha rpetrusha added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 24, 2019
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this LGTM @rpetrusha

I found one typo and made suggestion.

You can :shipit: when ready.

Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
@rpetrusha rpetrusha merged commit cb46620 into dotnet:master May 28, 2019
@rpetrusha rpetrusha deleted the xmlschema branch May 28, 2019 22:37
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work at all!
3 participants