Skip to content

Revised environment variable APIs for Unix-based systems #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2019
Merged

Revised environment variable APIs for Unix-based systems #2562

merged 2 commits into from
Jun 7, 2019

Conversation

rpetrusha
Copy link

Revised environment variable APIs for Unix-based systems

This PR:

  • Revises the EnvironmentVariableTargets documentation to note that only the process block is available on Unix-bases systems, and other targets results in NOPs.
  • Revised the Environment.GetEnvironmentVariable, Environment.GetEnvironmentVariables, and Environment.SetEnvironmentVariable APIs to better cover Unix-bases systems.
  • Includes extensively revised examples.

Related to dotnet/samples#959

Fixes #2399

@rpetrusha rpetrusha added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jun 6, 2019
@rpetrusha rpetrusha self-assigned this Jun 6, 2019
@rpetrusha
Copy link
Author

Closing and reopening to begin new build after dotnet/samples#959 has merged.

@rpetrusha rpetrusha closed this Jun 7, 2019
@rpetrusha rpetrusha reopened this Jun 7, 2019
BillWagner
BillWagner approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

You can :shipit: when ready.

@rpetrusha rpetrusha merged commit c5def54 into dotnet:master Jun 7, 2019
@rpetrusha rpetrusha deleted the envvars branch June 7, 2019 20:47
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EnvironmentVariableTarget is not usable for non-Windows platforms
3 participants
@rpetrusha @BillWagner @mairaw