Skip to content

Address Policheck issues, Part 3 #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

Address Policheck issues, Part 3 #2600

merged 2 commits into from
Jun 18, 2019

Conversation

rpetrusha
Copy link

Address Policheck issues, Part 3

The final set of Policheck-related changes.

@rpetrusha rpetrusha added this to the June 2019 milestone Jun 14, 2019
@rpetrusha rpetrusha self-assigned this Jun 14, 2019
mairaw
mairaw approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rpetrusha. Left a comment for you to consider.

xml/System.ServiceModel.Channels/ReceiveContext.xml Outdated
@@ -53,7 +53,7 @@
<format type="text/markdown"><![CDATA[

## Remarks
<xref:System.ServiceModel.Channels.ReceiveContext.Abandon%2A> may hang when there is an ambient transaction and <xref:System.ServiceModel.Channels.ReceiveContext.Complete%2A> is called and afterwards the transaction is rolled back. If <xref:System.ServiceModel.Channels.ReceiveContext.Abandon%2A> is called prior to the transaction rollback completing, a race condition will exist, causing the call to <xref:System.ServiceModel.Channels.ReceiveContext.Abandon%2A> to hang. This can be illustrated by the following pseudo-code example
<xref:System.ServiceModel.Channels.ReceiveContext.Abandon%2A> may block when there is an ambient transaction and <xref:System.ServiceModel.Channels.ReceiveContext.Complete%2A> is called and afterwards the transaction is rolled back. If <xref:System.ServiceModel.Channels.ReceiveContext.Abandon%2A> is called prior to the transaction rollback completing, a race condition will exist, causing the call to <xref:System.ServiceModel.Channels.ReceiveContext.Abandon%2A> to block. This can be illustrated by the following pseudo-code example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term database suggests stop responding as the official replacement. I think that sounds better than block?!?

@rpetrusha rpetrusha merged commit ebb4761 into dotnet:master Jun 18, 2019
@rpetrusha rpetrusha deleted the policheck3 branch September 4, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@rpetrusha @mairaw