Skip to content

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 3, 2019

No description provided.

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Jul 3, 2019
@mairaw mairaw added this to the July 2019 milestone Jul 3, 2019
@mairaw mairaw requested a review from karelz as a code owner July 3, 2019 08:02
@mairaw mairaw self-assigned this Jul 3, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left a couple of suggestions, @mairaw.
.

@@ -4695,7 +4695,7 @@
|<xref:System.Globalization.NumberStyles.AllowThousands>|The *,* element.|
|<xref:System.Globalization.NumberStyles.AllowCurrencySymbol>|The *$* element.|
|<xref:System.Globalization.NumberStyles.Currency>|All. The `s` parameter cannot represent a hexadecimal number or a number in exponential notation.|
|<xref:System.Globalization.NumberStyles.Float>|The *ws* element at the beginning or end of `s`, *sign* at the beginning of `s`, and the *.*symbol. The `s` parameter can also use exponential notation.|
|<xref:System.Globalization.NumberStyles.Float>|The *ws* element at the beginning or end of `s`, *sign* at the beginning of `s`, and the *.* symbol. The `s` parameter can also use exponential notation.|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|<xref:System.Globalization.NumberStyles.Float>|The *ws* element at the beginning or end of `s`, *sign* at the beginning of `s`, and the *.* symbol. The `s` parameter can also use exponential notation.|
|<xref:System.Globalization.NumberStyles.Float>|The *ws* element at the beginning or end of `s`, *sign* at the beginning of `s`, and the \*.\* symbol. The `s` parameter can also use exponential notation.|

There's also one other occurrence of the dropped *.* in the file.

Copy link
Contributor Author

@mairaw mairaw Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make the * appear. This just adds an space between . and the word symbol.

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@mairaw mairaw merged commit dcb650e into dotnet:master Jul 5, 2019
@mairaw mairaw deleted the markdig-fix branch July 5, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants