Skip to content

Add documentation for AsymmetricAlgorithm key import/export methods #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

bartonjs
Copy link
Member

After this gets merged I'll apply the documentation to the overrides (which will also gain algorithm-specific altmember/seealso values); and then follow up with algorithm-specific methods/formats.

@bartonjs
Copy link
Member Author

cc: @rpetrusha @mairaw @carlossanlop

@mairaw mairaw added the new-content Indicates PRs that contain new articles label Jul 20, 2019
@mairaw mairaw added this to the July 2019 milestone Jul 20, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @bartonjs. I've left a few suggestions and comments. One of the Remarks sections didn't appear in the build; hopefully, the issue will disappear with a new build.

@mairaw mairaw added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 24, 2019
@rpetrusha
Copy link

Thanks for the additional changes, @bartonjs. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 48e6fe1 into dotnet:master Jul 25, 2019
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants