Skip to content

Document System.Text.RegularExpressions.GroupCollection #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

carlossanlop
Copy link
Contributor

This one was interesting because the class implements IList and ICollection, which have shared method names.
Strangely, there were a couple of members that were duplicate, so I removed them. Please let me know if it was wrong to do so.

Here is the code: GroupCollection.cs

I based the documentation on the interface comments:

Area owners: @ViktorHofer, @maryamariyan
Language review: @rpetrusha, @Jemash

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Jul 23, 2019
@carlossanlop carlossanlop self-assigned this Jul 23, 2019
@rpetrusha rpetrusha removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 23, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a number of comments and suggestions, @carlossanlop. Most importantly, the members that you removed should be restored, since they evidently were supported in .NET Core 1.0 and 1.1.

@carlossanlop carlossanlop force-pushed the System.Text.RegularExpressions branch from 4bb2089 to fa094d6 Compare July 23, 2019 23:47
@carlossanlop
Copy link
Contributor Author

I addressed your comments, @rpetrusha. I had to to a git push -f so the previous commits are not showing up anymore, but I merged all your rewording suggestions, the EIIs and the "not supported" changed messages.

@carlossanlop carlossanlop added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 23, 2019
@mairaw mairaw added this to the July 2019 milestone Jul 24, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @carlossanlop. I thought that there were a few more places where we should add "This is an explicit interface implementation..."

@rpetrusha rpetrusha removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 25, 2019
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@carlossanlop
Copy link
Contributor Author

@mairaw @rpetrusha I applied your suggestions Ron, thanks for finding the additional remarks. I modified them a bit to include CDATA, otherwise the xrefs would give us trouble. Let me know if they look good while we wait for the build to finish.

@carlossanlop carlossanlop added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 26, 2019
@rpetrusha
Copy link

This looks good, @carlossanlop. I just noticed that there's one more EII (ICollection.CopyTo) that could have the "This member is an EII..." text, but I'll open a PR to add it separately, and I'll merge your PR now.

@rpetrusha rpetrusha merged commit 70ac4b1 into dotnet:master Jul 26, 2019
@carlossanlop carlossanlop deleted the System.Text.RegularExpressions branch July 26, 2019 17:36
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Text.RegularExpressions 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants