Display 0 as escaped #3025
Merged
Display 0 as escaped #3025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
added
the
✨ 1st-time dotnet-api-docs contributor!
rpetrusha
suggested changes
Aug 16, 2019
There was a problem hiding this comment.
Thank you, @tmpreston, for contributing to the dotnet/dotnet-api-docs repo and attempting to clarify the default value of the PasswordChar property. I'm not convinced, though, that escaping 0 accomplishes that. I suggested instead that the documentation instead mention the C# '0' syntax and the Unicode U+0000.
xml/System.Windows.Forms/TextBox.xml
Outdated
| @@ -858,7 +858,7 @@ | |||
| </ReturnValue> | |||
| <Docs> | |||
| <summary>Gets or sets the character used to mask characters of a password in a single-line <see cref="T:System.Windows.Forms.TextBox" /> control.</summary> | |||
| <value>The character used to mask characters entered in a single-line <see cref="T:System.Windows.Forms.TextBox" /> control. Set the value of this property to 0 (character value) if you do not want the control to mask characters as they are typed. Equals 0 (character value) by default.</value> | |||
| <value>The character used to mask characters entered in a single-line <see cref="T:System.Windows.Forms.TextBox" /> control. Set the value of this property to \0 (character value) if you do not want the control to mask characters as they are typed. Equals \0 (character value) by default.</value> | |||
There was a problem hiding this comment.
Suggested change
| <value>The character used to mask characters entered in a single-line <see cref="T:System.Windows.Forms.TextBox" /> control. Set the value of this property to \0 (character value) if you do not want the control to mask characters as they are typed. Equals \0 (character value) by default.</value> | |
| <value>The character used to mask characters entered in a single-line <see cref="T:System.Windows.Forms.TextBox" /> control. Set the value of this property to '0' (U+0000) if you do not want the control to mask characters as they are typed. The default value is '0' (U+0000).</value> |
rpetrusha
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)