Document System.Text.Json.Serialization.JsonConverter CreateConverter #3083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
rpetrusha,
mairaw,
ahsonkhan and
JeremyKuhne
carlossanlop
added
🏁 Release: .NET Core 3.0
rpetrusha
reviewed
Aug 26, 2019
There was a problem hiding this comment.
I made some changes, @carlossanlop. I think this is ready to merge, so I'll merge when the build completes successfully.
ahsonkhan
reviewed
Aug 27, 2019
rpetrusha
approved these changes
Aug 27, 2019
ahsonkhan
reviewed
Aug 27, 2019
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
|
All comments have been addressed, so I'll merge this now, @carlossanlop. |
rpetrusha
removed
the
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API added here: https://github.com/dotnet/corefx/pull/38702/files
Source: https://github.com/dotnet/corefx/blob/master/src/System.Text.Json/src/System/Text/Json/Serialization/JsonStringEnumConverter.cs#L55
Marked as inheritdoc. Parent comments here: https://github.com/dotnet/corefx/blob/master/src/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs
@ahsonkhan @JeremyKuhne @mairaw @rpetrusha