Automatically port System.Xml.Linq.XDocument triple slash #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
the
waiting-on-reviews
krwq
reviewed
Aug 27, 2019
xml/System.Xml.Linq/XDocument.xml
Outdated
| <param name="stream">A <see cref="T:System.IO.Stream" /> containing the raw XML to read into the newly created <see cref="T:System.Xml.Linq.XDocument" />.</param> | ||
| <param name="options">A set of <see cref="T:System.Xml.Linq.LoadOptions" />.</param> | ||
| <param name="cancellationToken">A cancellation token.</param> | ||
| <summary>Create a new <see cref="T:System.Xml.Linq.XDocument" /> and initialize its underlying XML tree using the passed <see cref="T:System.IO.Stream" /> parameter. Optionally whitespace handling can be preserved.</summary> |
There was a problem hiding this comment.
- nit: double space:
. Optionally Optionally whitespace handling can be preserved.=>Optionally whitespace can be preserved with PreserveWhitespace setting- otherwise it means something slightly different
There was a problem hiding this comment.
Thanks for catching it, @krwq. If you can, please use GitHub's suggestion feature, it's easier and faster to apply the changes with that feature.
There was a problem hiding this comment.
Suggested change
| <summary>Create a new <see cref="T:System.Xml.Linq.XDocument" /> and initialize its underlying XML tree using the passed <see cref="T:System.IO.Stream" /> parameter. Optionally whitespace handling can be preserved.</summary> | |
| <summary>Create a new <see cref="T:System.Xml.Linq.XDocument" /> and initialize its underlying XML tree using the passed <see cref="T:System.IO.Stream" /> parameter. Optionally whitespace handling can be preserved with the <see cref="F:System.Xml.Linq.LoadOptions.PreserveWhitespace" /> setting.</summary> |
rpetrusha
suggested changes
Aug 27, 2019
There was a problem hiding this comment.
I've left some suggestions for you to consider, @carlossanlop.
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
carlossanlop
commented
Sep 3, 2019
carlossanlop
commented
Sep 3, 2019
carlossanlop
commented
Sep 3, 2019
|
@mairaw @rpetrusha all comments addressed, build passed without warnings. Is this good to merge? |
rpetrusha
approved these changes
Sep 4, 2019
|
Yes, it's good to merge, @carlossanlop. I'll do that now. |
mairaw
removed
the
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Area owners @buyaa-n @krwq