Skip to content

Conversation

carlossanlop
Copy link
Contributor

Area owners @buyaa-n @krwq

@carlossanlop carlossanlop added the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Aug 27, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 27, 2019
@carlossanlop carlossanlop self-assigned this Aug 27, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for you to consider.

@mairaw
Copy link
Contributor

mairaw commented Aug 28, 2019

Also it seems that there a few exception that can occur. Do we also want to include that as part of this PR?

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@carlossanlop
Copy link
Contributor Author

Also it seems that there a few exception that can occur. Do we also want to include that as part of this PR?

This PR is only for automatic porting existing comments.
@krwq and @buyaa-n, since you own the code, would you mind adding the missing exceptions in a separate PR?

@mairaw
Copy link
Contributor

mairaw commented Sep 5, 2019

I'll open an issue so we can track that separately then.

@carlossanlop
Copy link
Contributor Author

@mairaw @rpetrusha this is not 3.0, but the build passed without warnings so we can get it merged if you agree.

@carlossanlop
Copy link
Contributor Author

@mairaw @rpetrusha can we get this merged?

@mairaw
Copy link
Contributor

mairaw commented Sep 9, 2019

Issue opened: #3148

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@mairaw mairaw merged commit d0b691f into dotnet:master Sep 10, 2019
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Sep 10, 2019
@carlossanlop carlossanlop deleted the XElement branch November 6, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants