Skip to content

Automatically port System.Text.Encodings #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 10, 2019
Merged

Automatically port System.Text.Encodings #3151

merged 8 commits into from
Sep 10, 2019

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Sep 9, 2019
@carlossanlop carlossanlop added this to the September 2019 milestone Sep 9, 2019
@carlossanlop carlossanlop self-assigned this Sep 9, 2019
ahsonkhan
ahsonkhan reviewed Sep 9, 2019
View reviewed changes
jozkee
jozkee reviewed Sep 9, 2019
View reviewed changes
@carlossanlop @jozkee
Update xml/System.Text.Encodings.Web/TextEncoder.xml
43b19be 
Co-Authored-By: David Cantu <jozkyy@gmail.com>
rpetrusha
rpetrusha suggested changes Sep 9, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested some changes, @carlossanlop. In particular (and perhaps it's just me), I found the reversal of true and false values confusing, since the initial description of the parameter value describes what the named parameter is not.

ahsonkhan
ahsonkhan reviewed Sep 9, 2019
View reviewed changes
ahsonkhan
ahsonkhan reviewed Sep 9, 2019
View reviewed changes
ahsonkhan
ahsonkhan approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those changes, look's good.

@carlossanlop
suggestions by rpetrusha and ahsonkhan
cc5cf73 
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
jozkee
jozkee reviewed Sep 10, 2019
View reviewed changes
@carlossanlop @jozkee
Update xml/System.Text.Encodings.Web/TextEncoder.xml
abf974c 
Co-Authored-By: David Cantu <jozkyy@gmail.com>
@carlossanlop carlossanlop added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Sep 10, 2019
@rpetrusha rpetrusha merged commit 0a9aa7b into dotnet:master Sep 10, 2019
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Oct 2, 2019
@carlossanlop carlossanlop deleted the TextEncoder branch November 6, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jozkee jozkee jozkee left review comments

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

@mairaw mairaw Awaiting requested review from mairaw

+2 more reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.
5 participants
@carlossanlop @ahsonkhan @rpetrusha @jozkee @mairaw