Document System.IO.BinaryReader Read methods #3206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
commented
Sep 17, 2019
| <summary>To be added.</summary> | ||
| <returns>To be added.</returns> | ||
| <param name="buffer">A region of memory. When this method returns, the contents of this region are replaced by the bytes read from the current source.</param> | ||
| <summary>Reads a sequence of bytes from the current stream and advances the position within the stream by the number of bytes read.</summary> |
There was a problem hiding this comment.
Essentially the same as calling Stream.Read(Span):
https://github.com/dotnet/corefx/blob/65edbb39dd737e8529a343f385d2600e482b7ff3/src/Common/src/CoreLib/System/IO/BinaryReader.cs#L477
carlossanlop
commented
Sep 17, 2019
| <summary>To be added.</summary> | ||
| <returns>To be added.</returns> | ||
| <param name="buffer">A span of characters. When this method returns, the contents of this region are replaced by the characters read from the current source.</param> | ||
| <summary>Reads, from the current stream, the same number of characters as the length of the provided buffer, writes them in the provided buffer, and advances the current position in accordance with the <see langword="Encoding" /> used and the specific character being read from the stream.</summary> |
There was a problem hiding this comment.
rpetrusha
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
This looks good, @carlossanlop. I did change all occurrences of "An IO error occurs" to "An IO error occurred. But I think that this can be merged once the build completes.
rpetrusha
added
verify-build-before-merge
and removed
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.