Skip to content

Document System.Version #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2019
Merged

Document System.Version #3232

merged 2 commits into from
Sep 26, 2019

Conversation

carlossanlop
Copy link
Contributor

No description provided.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Sep 24, 2019
@carlossanlop carlossanlop added this to the September 2019 milestone Sep 24, 2019
@carlossanlop carlossanlop self-assigned this Sep 24, 2019
mairaw
mairaw approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made some edits - please review.

@mairaw mairaw added verify-build-before-merge waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews verify-build-before-merge labels Sep 25, 2019
@carlossanlop
Copy link
Contributor Author

Your changes look good, @mairaw, thanks for making them. Ready to merge!

@mairaw mairaw removed the waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged label Sep 26, 2019
@mairaw mairaw merged commit 2576558 into dotnet:master Sep 26, 2019
@carlossanlop carlossanlop deleted the Version branch October 21, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@rpetrusha rpetrusha Awaiting requested review from rpetrusha

Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @mairaw