Skip to content

Document System.IO.Enumeration.FileSystemEnumerable #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 5, 2019
Merged

Document System.IO.Enumeration.FileSystemEnumerable #3413

merged 5 commits into from
Nov 5, 2019

Conversation

carlossanlop
Copy link
Contributor

Missing constructor documentation.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Oct 25, 2019
@carlossanlop carlossanlop added this to the October 2019 milestone Oct 25, 2019
@carlossanlop carlossanlop self-assigned this Oct 25, 2019
mairaw
mairaw approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @carlossanlop. Made a small edit and left a few comments for you to consider.

@carlossanlop carlossanlop added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Nov 1, 2019
mairaw
mairaw approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Nov 1, 2019
@mairaw mairaw merged commit 02b0606 into dotnet:master Nov 5, 2019
@carlossanlop carlossanlop deleted the FileSystemEnumerable branch November 6, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @mairaw