Skip to content

Document TryParse Span method overloads for System.I-U #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2019
Merged

Document TryParse Span method overloads for System.I-U #3434

merged 3 commits into from
Nov 14, 2019

Conversation

carlossanlop
Copy link
Contributor

Types: Int16, Int32, Int64, SByte, Single, TimeSpan, UInt16, UInt32, UInt64.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Nov 2, 2019
@carlossanlop carlossanlop added this to the November 2019 milestone Nov 2, 2019
@carlossanlop carlossanlop self-assigned this Nov 2, 2019
@carlossanlop carlossanlop changed the title Document TryParse Span methods overloads for System.I-U Document TryParse Span method overloads for System.I-U Nov 2, 2019
@carlossanlop carlossanlop requested a review from a team November 7, 2019 08:58
@Thraka Thraka assigned carlossanlop and Thraka and unassigned carlossanlop Nov 8, 2019
@Thraka Thraka removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Nov 8, 2019
Thraka
Thraka approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@Thraka Thraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I noted a few differences and 1 problem you should fix. But I won't hold you up. Cheers!

carlossanlop and others added 2 commits November 14, 2019 10:31
@carlossanlop @Thraka
suggestions by Thraka
0d77e04 
Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
@carlossanlop @Thraka
suggestion by Thraka
772a734 
Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
@carlossanlop carlossanlop merged commit d2cebd7 into dotnet:master Nov 14, 2019
@carlossanlop carlossanlop deleted the TryParse_Span_I-U branch November 14, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Thraka Thraka Thraka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

@Thraka Thraka

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @Thraka @mairaw