Add missing DateTime/DateTimeOffset/TimeSpan docs #3500
Conversation
carlossanlop
added
🏁 Release: .NET Core 2.x
Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
| <returns>To be added.</returns> | ||
| <param name="ts">The value to be divided by.</param> | ||
| <summary>Returns a new <see cref="T:System.Double" /> value which is the result of division of this instance and the specified <paramref name="ts" />.</summary> | ||
| <returns>A new value that represents result of division of this instance by the value of the <paramref name="ts" />.</returns> |
There was a problem hiding this comment.
value [](start = 23, length = 5)
should be ticks value
There was a problem hiding this comment.
isn't the result unit-less? We divide time by time so you should get a ratio back
There was a problem hiding this comment.
it is not ratio more than real ticks. If you are dividing 2 times what the result means to you? and how you can use it later? it should have some meaning. right?
There was a problem hiding this comment.
I see, I think this comment was meant to be on the overload above (TimeSpan/double). For this one (TimeSpan/TimeSpan) 4s divided by 2s means it's 2 times longer
There was a problem hiding this comment.
(note the above one mentions TimeSpan object not value)
| <param name="t1">Divident or the value to be divided.</param> | ||
| <param name="t2">The value to be divided by.</param> | ||
| <summary>Returns a new <see cref="T:System.Double" /> value which is the result of division of <paramref name="t1" /> instance and the specified <paramref name="t2" />.</summary> | ||
| <returns>A new value that represents result of division of <paramref name="t1" /> instance by the value of the <paramref name="t2" />.</returns> |
There was a problem hiding this comment.
value [](start = 23, length = 5)
should be ticks value
|
added some minor comments. otherwise LGTM. |
|
@krwq let us know if you're going to make these changes. When you're ready, we'll merge. Thanks! |
|
I'm good with merging as is |
mairaw
removed
the
waiting-on-reviews
Add missing DateTime/DateTimeOffset/TimeSpan docs
cc: @carlossanlop @tarekgh