-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Missing API docs part 1 - SA #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to missing_api_docs_1
@mairaw Including you on review |
Build failed with a weird error message. Trying to build again. |
@mairaw Yes, I have some unescaped characters in one of the files; fixing them now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @steveada! I've left a few comments. The old IntelliSense files I sent you should be helpful to recover the previous existing descriptions where I commented.
@@ -32,7 +32,7 @@ | |||
</Attribute> | |||
</Attributes> | |||
<Docs> | |||
<typeparam name="TResult">To be added.</typeparam> | |||
<typeparam name="TResult">The type of the return value of the C# reference.</typeparam> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillWagner do you think we could just say this?
<typeparam name="TResult">The type of the return value of the C# reference.</typeparam> | |
<typeparam name="TResult">The type of the C# reference.</typeparam> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you @steveada!
Totals 51 rows over 12 files