-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Missing API docs part 2 - SA #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to missing_api_docs_2
@KathleenDollard FYI that @mairaw will be assigning herself as reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @steveada. Left you some comments for you to consider before we merge this.
You can batch all my suggestions into a single commit using https://github.com/dotnet/dotnet-api-docs/pull/3567/files |
Suggestions from SME review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two missing property values...
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@mairaw Ready to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready @steveada. Thanks!
@mairaw 42 changes in 9 files