Skip to content

Missing API docs part 4 - SA #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 12, 2019
Merged

Conversation

steveada
Copy link
Contributor

@steveada steveada commented Dec 9, 2019

@mairaw 20 changes in 5 files

@dotnet-bot dotnet-bot added this to the December 2019 milestone Dec 9, 2019
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Dec 10, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steveada. Left a few suggestions for you to address. You can batch them in a single commit via https://github.com/dotnet/dotnet-api-docs/pull/3654/files.

@steveada
Copy link
Contributor Author

@mairaw This one looks good to go now

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @steveada!

@mairaw mairaw merged commit a5ca6ee into dotnet:master Dec 12, 2019
@steveada steveada deleted the missing_api_docs_4 branch December 12, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants