Skip to content

Document System.Buffers.Text namespace #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2019

Conversation

carlossanlop
Copy link
Contributor

Thank you @layomia for providing the description.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Dec 13, 2019
@carlossanlop carlossanlop added this to the December 2019 milestone Dec 13, 2019
@carlossanlop carlossanlop requested review from layomia, jozkee and a team December 13, 2019 01:32
@carlossanlop carlossanlop self-assigned this Dec 13, 2019
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @ahsonkhan

Co-Authored-By: Layomi Akinrinade <layomia@gmail.com>
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small suggestion.

Co-Authored-By: Genevieve Warren <gewarren@microsoft.com>
@carlossanlop carlossanlop merged commit 5e08b13 into dotnet:master Dec 14, 2019
@carlossanlop carlossanlop deleted the nsSystemBuffersText branch December 14, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants