String.xml -- Try .NET -- replacing out-of-sync PR 3458 #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw -- Maira, please review this (hopefully last of this series) version of String.xml, which includes all the new interactive sample refs. |
mairaw
added
the
vendor-project
mairaw
requested changes
Jan 17, 2020
There was a problem hiding this comment.
Thank you @WilliamAntonRohm. I can't edit this file directly, so leaving review comments for you to address please.
|
New build now that samples change was merged. |
mairaw
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new samples PR is dotnet/samples#1916
replaces #3458
started with an up-to-date copy of String.xml & re-interactivated sample file references