Skip to content

Automatic port of System.Collections.Immutable #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 6, 2020
Merged

Automatic port of System.Collections.Immutable #3946

merged 6 commits into from
Mar 6, 2020
+56 −53

Conversation

carlossanlop
Copy link
Contributor

These comments were automatically ported directly from triple slash.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews Release: .NET Core 1.x labels Feb 27, 2020
@carlossanlop carlossanlop added this to the February 2020 milestone Feb 27, 2020
@carlossanlop carlossanlop self-assigned this Feb 27, 2020
@carlossanlop carlossanlop requested a review from a team February 27, 2020 04:23
mairaw
mairaw reviewed Feb 27, 2020
View reviewed changes
@mairaw
Copy link
Contributor

mairaw commented Feb 27, 2020

Didn't reviewed everything. Just made some quick comments on some things I saw.

carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
carlossanlop
carlossanlop commented Feb 28, 2020
View reviewed changes
@carlossanlop @mairaw
suggestions by mairaw
ad24cd1 
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@carlossanlop
Copy link
Contributor Author

@eiriktsarpalis @layomia can you please help review? We also need to substitute the strings that say "see the ImmutableDictionary interface" with actual descriptions.

eiriktsarpalis
eiriktsarpalis reviewed Mar 2, 2020
View reviewed changes
eiriktsarpalis
eiriktsarpalis reviewed Mar 2, 2020
View reviewed changes
eiriktsarpalis
eiriktsarpalis reviewed Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
carlossanlop and others added 2 commits March 2, 2020 10:35
@carlossanlop @eiriktsarpalis
Apply suggestions from code review
5257b1b 
Co-Authored-By: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@carlossanlop
overwrite -> replace
0e036e3
@BillWagner BillWagner modified the milestones: February 2020, March 2020 Mar 2, 2020
carlossanlop
carlossanlop commented Mar 2, 2020
View reviewed changes
@carlossanlop @eiriktsarpalis
Apply suggestions from code review
5469124 
Co-Authored-By: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
carlossanlop
carlossanlop commented Mar 5, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 5, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 5, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 5, 2020
View reviewed changes
carlossanlop
carlossanlop commented Mar 5, 2020
View reviewed changes
@carlossanlop
Copy link
Contributor Author

@layomia @eiriktsarpalis some of the ported strings were poorly written. I reverted them to "To be added" and will defer the task of getting them properly documented to you :)

@carlossanlop carlossanlop added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Mar 5, 2020
@carlossanlop carlossanlop merged commit 771bd48 into dotnet:master Mar 6, 2020
@carlossanlop carlossanlop deleted the Collections branch March 6, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@mairaw mairaw mairaw left review comments

@layomia layomia Awaiting requested review from layomia

Assignees

@carlossanlop carlossanlop

Labels
new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @mairaw @eiriktsarpalis @BillWagner