Skip to content

Automatically port Char comments (EII) #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Automatically port Char comments (EII) #4019

merged 1 commit into from
Mar 24, 2020

Conversation

carlossanlop
Copy link
Contributor

Fixes some APIs from: #3934

@carlossanlop carlossanlop added this to the March 2020 milestone Mar 21, 2020
@carlossanlop carlossanlop requested a review from a team March 21, 2020 06:16
@carlossanlop carlossanlop self-assigned this Mar 21, 2020
@BillWagner BillWagner requested review from BillWagner and removed request for a team March 24, 2020 14:24
BillWagner
BillWagner approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @carlossanlop

I'll :shipit: now.

@BillWagner BillWagner merged commit c54bdcd into dotnet:master Mar 24, 2020
@carlossanlop carlossanlop deleted the EIIChar branch March 24, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@carlossanlop carlossanlop

Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @BillWagner