Skip to content

fix return value formatting #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2020
Merged

fix return value formatting #4093

merged 1 commit into from
Apr 10, 2020

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 9, 2020

@mairaw mairaw requested a review from a team as a code owner April 9, 2020 19:48
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 9, 2020
gewarren
gewarren approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending preview verification. What about the vertical text in the table, is that expected?

@gewarren
Copy link
Contributor

gewarren commented Apr 9, 2020

Ah, looks good now.

https://review.docs.microsoft.com/en-us/dotnet/api/system.int32.system-icomparable-compareto?view=netstandard-1.6&branch=pr-en-us-4093#returns

@mairaw
Copy link
Contributor Author

mairaw commented Apr 10, 2020

Yeah, it was caused by the long cell.

@mairaw mairaw merged commit 2b1d05e into master Apr 10, 2020
@mairaw mairaw deleted the mairaw-patch-1 branch April 10, 2020 00:30
@mairaw mairaw mentioned this pull request Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@mairaw @gewarren @dotnet-bot