Skip to content

Delete _moniker2Assembly.json and use type forwarding info instead #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

TianqiZhang
Copy link
Contributor

With mdoc 5.7.5.4 release, we now have reliable type forwarding info in ECMAXML, so we can get rid of _moniker2Assembly.json now.

@TianqiZhang TianqiZhang requested a review from a team as a code owner April 14, 2020 08:33
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 14, 2020
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TianqiZhang

This LGTM. I'll :shipit: now.

@BillWagner BillWagner merged commit 91d5f8f into master Apr 14, 2020
@BillWagner BillWagner deleted the tianzh/assemblies branch April 14, 2020 12:32
TianqiZhang added a commit that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants