Skip to content

.NET Interactive: Enable_try_dotnet_to_batch_4a #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2020
Merged

.NET Interactive: Enable_try_dotnet_to_batch_4a #4110

merged 2 commits into from
Apr 14, 2020

Conversation

@v-mepa v-mepa requested review from eerhardt and pgovind as code owners April 14, 2020 18:23
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 14, 2020
@mairaw mairaw requested review from mairaw and removed request for eerhardt and pgovind April 14, 2020 19:24
@mairaw mairaw added vendor-project Indicates the issue/pr is related to a vendor project. 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs labels Apr 14, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great @v-mepa! The only thing missing is the example from the remarks section for https://docs.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.capture.value.

@v-mepa
Copy link
Contributor Author

v-mepa commented Apr 14, 2020

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great!

@mairaw mairaw merged commit 0cd6338 into dotnet:master Apr 14, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_4a branch April 14, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project. 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants