Skip to content

Fix ChangePassword description #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

Fix ChangePassword description #4113

merged 1 commit into from
Apr 25, 2020

Conversation

uecasm
Copy link
Contributor

@uecasm uecasm commented Apr 15, 2020

The existing text implies that ChangePassword will modify the password contained in the SqlCredential, which is not at all what it actually does.

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 15, 2020
@carlossanlop
Copy link
Contributor

carlossanlop commented Apr 24, 2020 •
edited
Loading

@cheenamalhotra @David-Engel @karinazhou @JRahnama can you please review?
Edit: Apologies, @cheenamalhotra , I realized you had already approved this, after I sent this comment. Thank you!

@carlossanlop carlossanlop requested a review from a team April 24, 2020 21:34
@carlossanlop carlossanlop merged commit d1cac3c into dotnet:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@karinazhou karinazhou karinazhou approved these changes

@David-Engel David-Engel Awaiting requested review from David-Engel

@JRahnama JRahnama Awaiting requested review from JRahnama

Assignees

@uecasm uecasm

Labels
None yet
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@uecasm @carlossanlop @cheenamalhotra @karinazhou @dotnet-bot