Skip to content

System.Data 1.x undocumented APIs #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2020
Merged

Conversation

David-Engel
Copy link
Contributor

Summary

Takes care of some undocumented APIs owned by System.Data.Common and System.Data.SqlClient. that were all introduced in 1.x.

Fixes #3910

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 13, 2020
@David-Engel
Copy link
Contributor Author

@carlossanlop carlossanlop requested a review from a team May 15, 2020 18:22
@carlossanlop
Copy link
Contributor

Thank you @David-Engel for the PR. The changes look good.
Do any of these APIs throw exceptions? If yes, can you please add them? The xml items for exceptions have to be manually added below the remarks item, like this:

    <remarks>To be added.</remarks>
    <exception cref="T:System.WhateverException">The reason why the exception is thrown.</exception>

@David-Engel
Copy link
Contributor Author

@carlossanlop

Do any of these APIs throw exceptions? If yes, can you please add them?

Added.

@ajcvickers
Copy link

Thanks @David-Engel!

@David-Engel
Copy link
Contributor Author

@carlossanlop Anything else needed before merging this PR?

Thanks,
David

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates here @David-Engel

I'll :shipit: now.

@BillWagner BillWagner merged commit db60afc into dotnet:master May 26, 2020
@David-Engel David-Engel deleted the system-data branch May 27, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Data 1.x undocumented APIs
6 participants