-
Notifications
You must be signed in to change notification settings - Fork 1.6k
System.Data 1.x undocumented APIs #4233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixing dispose doc error
Not sure why the CI is not providing a review links, but here are a couple starters: |
Thank you @David-Engel for the PR. The changes look good. <remarks>To be added.</remarks>
<exception cref="T:System.WhateverException">The reason why the exception is thrown.</exception> |
Added. |
Thanks @David-Engel! |
@carlossanlop Anything else needed before merging this PR? Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the updates here @David-Engel
I'll now.
Summary
Takes care of some undocumented APIs owned by System.Data.Common and System.Data.SqlClient. that were all introduced in 1.x.
Fixes #3910