ReadOnlyMemoryContent class description #4277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
reviewed
May 27, 2020
ManickaP
reviewed
Jun 2, 2020
ManickaP
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
It follows the same pattern as documentation of ByteArrayContent, so I'm fine with it as it is. Although, IMHO the documentation could be greatly improved with more substantial details, like examples and usages.
Apart from the comments, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Collect all changes from #3916 related to ReadOnlyMemoryContent